take match scores for all words into account #7652
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7645
this does give the behavior i expect, although i'm not sure if this is now doing duplicated work because it has to call both
matches
andfuzzy_match
(orindices
andfuzzy_indices
) on each item - it feels like it should be able to do just one or the other? but i'm not sure what api would make sense here, the fuzzy-matcher interface is pretty hard for me to understand. it doesn't appear to be obviously slower than before though, although i didn't do any benchmarking.